Bug 5719 - SM not looking for mapcycle in all possible locations
SM not looking for mapcycle in all possible locations
Status: RESOLVED FIXED
Product: SourceMod
Classification: Unclassified
Component: Base Plugins
1.5 branch
All All
: P5 enhancement
Assigned To: Nicholas Hastings [:psychonic]
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-24 21:08 PDT by 1nsane.pw
Modified: 2013-08-07 09:33 PDT (History)
6 users (show)

See Also:


Attachments
Check other paths where applicable (2.52 KB, patch)
2013-07-31 19:58 PDT, Nicholas Hastings [:psychonic]
asherkin: review+
Details | Diff | Splinter Review

Description 1nsane.pw 2013-04-24 21:08:12 PDT
Hello,

The steampipe update made some changes to where the default mapcycle files go. As of this posting default mapcycles for TF2 go into the /tf/cfg folder. While the rest of steampipe orangebox games have it in the old location of /gamename/mapcycle.txt. But based on what I know CS:S is going to also look for the mapcycle in the /cfg/ folder soon if it doesn't already. I don't know about the other games.

There's also another location where mapcycle files can go /custom/some_folder_name/cfg.

If sourcemod used valve's filesystem it would be able to locate the right file. 

Or perhaps alternatively a new cvar could be added to point the location of the file relative to the /gamename/ folder. Similar to the existing "mapcyclefile" cvar built into srcds except it would accept a folder path as well.

There might be other cases of sourcemod looking for some custom file in the wrong folder. But I don't have much custom content anymore so I didn't test that. It might already be loading other custom files correctly.
Comment 1 Erik Minekus 2013-05-14 03:52:23 PDT
Duplicate of bug 5715.
Comment 2 Nicholas Hastings [:psychonic] 2013-05-14 03:56:55 PDT
(In reply to comment #1)
5715 is regarding maps themselves whereas this one is regarding the mapcyclefile.

It is two separate issues.
Comment 3 Nicholas Hastings [:psychonic] 2013-07-31 19:58:27 PDT
Created attachment 3474 [details] [review]
Check other paths where applicable
Comment 4 Nicholas Hastings [:psychonic] 2013-07-31 20:02:00 PDT
Pushed changeset: http://hg.alliedmods.net/sourcemod-central/rev/5d8b87f98355
Changelog:
	Check all possible mapcycle paths on newer orangebox games (bug 5719, r=asherkin).
Comment 5 Nicholas Hastings [:psychonic] 2013-07-31 20:55:51 PDT
Pushed changeset: http://hg.alliedmods.net/releases/sourcemod-1.5/rev/56877a694a0b
Changelog:
	Check all possible mapcycle paths on newer orangebox games (bug 5719, r=asherkin).
Comment 6 Nicholas Hastings [:psychonic] 2013-08-05 08:37:21 PDT
Pushed changeset: http://hg.alliedmods.net/sourcemod-central/rev/5c5ed57cca88
Changelog:
	Fixed a path not using updated mapcycle file detection (bug 5719).
Comment 7 Nicholas Hastings [:psychonic] 2013-08-05 08:38:11 PDT
Pushed changeset: http://hg.alliedmods.net/releases/sourcemod-1.5/rev/78e5f0250b75
Changelog:
	Fixed a path not using updated mapcycle file detection (bug 5719).
Comment 8 winnie 2013-08-07 09:24:20 PDT
The mapcyclefile can also be searched for in a path specified by -insert_search_path.

If in the launch parameters there is -insert_search_path cstrike/instances/css1 a mapcyclefile could be found in /cstrike/instances/css1/cfg/<mapcyclefile>.txt
Comment 9 Nicholas Hastings [:psychonic] 2013-08-07 09:33:12 PDT
(In reply to winnie from comment #8)
Please file a separate bug for that.

This bug was related to not checking all relative game paths whereas you're referring to looking for that relative path in all valve file system search paths (which would be a valid request.

Note You need to log in before you can comment on or make changes to this bug.