Bug 5482 - game.nmrih.txt out of date
game.nmrih.txt out of date
Status: RESOLVED FIXED
Product: SourceMod
Classification: Unclassified
Component: SDKTools
1.4 branch
All All
: P5 enhancement
Assigned To: SourceMod Bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-12 07:04 PDT by rlh2006
Modified: 2012-11-06 07:19 PST (History)
7 users (show)

See Also:


Attachments
Patch (1.86 KB, patch)
2012-10-02 10:08 PDT, Reuben Morais
no flags Details | Diff | Splinter Review

Description rlh2006 2012-09-12 07:04:04 PDT
The "game.nmrih.txt" inside of sourcemod/gamedata/sdktools.games shows that it is for version 1.02 ("* No More Room in Hell 1.02 *"), but the game (NMRiH) was updated on 9/7/2012 to version 1.05. They added some new weapons and such, so these changes make some plugins not work.

For example, the unlimited ammo plugin will not work at all since the update to v. 1.05. The offsets have changed or something.
Comment 1 pizzahut 2012-09-25 05:11:09 PDT
For servers there is an additional patch, not sure if this also changes the gamedata offsets: http://www.nomoreroominhell.com/news/162
Comment 2 rlh2006 2012-10-02 06:18:57 PDT
Chanz updated the gamedata.

Thanks Chanz.

Re: http://www.nomoreroominhell.com/forums/index.php?showtopic=8784
Comment 3 pizzahut 2012-10-02 07:47:08 PDT
I wouldn't change it to resolved until it's included in SourceMod, thanks though for the info, and thanks Chanz for the fix.
Comment 4 Powerlord 2012-10-02 08:25:32 PDT
I'd have to agree with pizzahut here.  Ideally, the SourceMod devs should be the only ones marking bugs as fixed.
Comment 5 Reuben Morais 2012-10-02 10:08:23 PDT
Created attachment 3137 [details] [review]
Patch

Silly Chanz!
Comment 6 chanz 2012-10-02 10:33:59 PDT
(In reply to comment #5)
All offsets are taken from http://www.sourcemodplugins.org/vtableoffsets/nmrih
So there could be errors in the windows offsets, since they are guessed.

Or why did you call me silly? :)
Comment 7 Erin Baker [:asherkin] 2012-10-02 10:39:39 PDT
(In reply to comment #6)
Have you at least tested them on Windows? That site still doesn't appear to handle Multiple Inheritance in it's calculations.

https://forums.alliedmods.net/showthread.php?t=191328
Comment 8 chanz 2012-10-02 10:42:00 PDT
Sorry no, I tested them only on linux.
Comment 9 Reuben Morais 2012-10-02 12:04:50 PDT
(In reply to comment #6)
Because you should have posted the updated gamedata in a bug. But now I see it was all a play to trick me into posting an untested patch… Silly me!
Comment 10 Nicholas Hastings [:psychonic] 2012-10-14 15:26:37 PDT
Pushed changeset: http://hg.alliedmods.net/sourcemod-central/rev/f0158c944e0e
Changelog:
	Updated NMRiH gamedata (bug 5482).
Comment 11 Nicholas Hastings [:psychonic] 2012-10-14 15:32:52 PDT
Pushed changeset: http://hg.alliedmods.net/releases/sourcemod-1.4/rev/a91a6bcd68dd
Changelog:
	Updated NMRiH gamedata (bug 5482).
Comment 12 Nicholas Hastings [:psychonic] 2013-02-09 17:59:05 PST
Pushed changeset: http://hg.alliedmods.net/sourcemod-experimental/rev/f0158c944e0e
Changelog:
	Updated NMRiH gamedata (bug 5482).

Note You need to log in before you can comment on or make changes to this bug.