Bugzilla – Bug 2852
Missing translations for miscstats/statsx and new misc messages
Last modified: 2014-07-28 13:55:27 PDT
There is something missing with translation of statsx/miscstats. Items of StatsCfgMenu aren't translated. Most Disruptive, Best Player of the round is translated only into server language (should be used LANG_PLAYER instead LANG_SERVER for these translations). I rewrote 3 plugins - statsx, miscstats and statscfg to use translations in statscfgmenu and I've added few new messages they are already added also in AMX 2005/6 based on my plugin I posted at AMX forum 1.5 year ago here. There are also new messages (water kill, air kill, kill through the wall, fall down suicide) done by KRoT@L in AMX newest version (but re-wrote by me to use fakemeta instead engine - except client_kill function - to do: air kill doesn't work corredctly with fakemeta). Currently missing translations are: sr, tr, sv, da, nl, es, cz, fi, ls, bg The files are updated with all fixes done in default miscstats plugin since revision 3099 until revision 3142 including (now You need only add the fix for the problem with rounding mp_roundtime which was done wrong since the beginning and it was causing not displaying HUD messages when mp_roundtime was 3.1 or so) You can grab my files from that post: http://forums.alliedmods.net/showpost.php?p=386462&postcount=3 Original topic was here: http://forums.alliedmods.net/showthread.php?t=25139 It was promissed to be added for 1.77 here: http://forums.alliedmods.net/showpost.php?p=387066&postcount=8
Just to say that this version works fine on my server. Except air kill. ;) Thanks again KWo. :)
I have merged in a few of your bug fixes and some of the translation stuff. The other stats plugins need to be ported. I don't know if we'll do this or not, since translating the statscfgmenu has basically no purpose anyway. But I'm leaving this report open until we make a decision. As for your other changes, I'm reluctant to merge them in. I can't find a single useful comment and there is no changelog detailing what each change is, or what any of the changes are. I am also keeping this report open until I can fix the LANG_SERVER usage which still appears to be plaguing statsx.
"I don't know if we'll do this or not, since translating the statscfgmenu has basically no purpose anyway." - the purpose is the same as for the whole amxmodmenu translation - if that one is translated (to let the people understand what they are changing) - statscfgmenu should be translated, too. Another thing - it was translated in AMX, too - the migrating people may start to ask about it in the future anyway. But if I rememeber good I did it - if there is just only the problem for You You cannot find these changes in my code - I can help to find them. "I can't find a single useful comment and there is no changelog detailing what each change is, or what any of the changes are." The changelog wasn't written at once. The one part was written in that dJeyl's forum I pointed the link in my post with my files. Here they go: - Bomb Cound Down HUD message for all players, - delaying or disabling show some HUD messages using 3 and 4 channnel for "just killed" players, to prevent overwrite their attackers and victims list, - added killingspree HUD messages from some old Ditka's plugin, - added info how many seconds before explosion the bomb has been defused. The rest of changelog was written here:http://forums.alliedmods.net/showpost.php?p=386462&postcount=3 "KWo - There are also new messages (water kill, air kill, kill through the wall, fall down suicide) done by KRoT@L in AMX newest version (but re-wrote by me to use fakemeta instead engine - except client_kill function)." I didn't think the trivial functions they are added/changed there they need to be commented line by line... From Your post I've got this - some of the changes You already understood and You have included them (but because there was no comment it's taking too much of Your time) - so at least those changes they don't need to be commented by me anymore. So please just specify what functions/changes You still need I comment for You, then I'll try to help the best I'll be able (to prevent me at least to comment this what You have already was working on).
KWo, if you are still around, could you make a pull request with your changes on GitHub?